search

joeferner / redis-commander

Redis management tool written in node.js
http://joeferner.github.io/redis-commander/
MIT License
3.56k stars 460 forks source link

istio virtual service added #545

Closed nagyzekkyandras closed 7 months ago

nagyzekkyandras commented 9 months ago

In some cases we have to use Istio instead of Ingress. For this I added the VirtualService to helm chart.

sseide commented 8 months ago

Thanks for the PR. Currently the value "istio.enabled" is not evaluated and the VirtualService rendered every time. Please add a if clause around the VirtualService similar to the "hpa" template to only render it if enabled.

sseide commented 8 months ago

And another change - the ".Values.istio.host" field should be an array to list multiple names (e.g. different external/internal names) similar to the ingress template.

And please add the default "labels" and "annotations" to the VirtualService too (same as ingress again).