joeferner / redis-commander

Redis management tool written in node.js
http://joeferner.github.io/redis-commander/
MIT License
3.56k stars 460 forks source link

default values of k8s helm chart #552

Closed gaal-dev closed 6 months ago

gaal-dev commented 7 months ago

Hello. I've got the same error.

https://github.com/joeferner/redis-commander/issues/543

"$ helm install redis-commander -f ./values.yaml . -n redis And get error: Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: unknown object type "nil" in ConfigMap.data.local-production.json"

It happens here because connections does not have any local_production_json value

configmap.yaml: local-production.json: {{ .Values.connections.local_production_json | toJson }}

Please, add this fix. It works for me.

connections: local_production_json: ""

sseide commented 6 months ago

Hello,

can you test again with latest version? The handling of possible config file from configmap is changed now. Config map is only referenced if needed within the deployment.

gaal-dev commented 6 months ago

Hello, can you test again with latest version?

It works :)

gaal-dev commented 6 months ago

Tested and closed