joeferraro / react-native-cookies

Cookie manager for React Native
MIT License
788 stars 314 forks source link

Now I download the latest version, but gradle's buildToolsVersion is still fixed at 25.0.2. Can it be new? #129

Open jacintoface opened 5 years ago

jacintoface commented 5 years ago

problem like title, thanks

ethanyuwang commented 5 years ago

Great question. This outdated dependency actually caused me a problem when I tried to compile a release build with react-native: 0.58.4. I copied off a build.gradle from another project that would use the parent project's dependencies if available:

def safeExtGet(prop, fallback) {
    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

buildscript {
    repositories {
        jcenter()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:1.5.0'
    }
}

apply plugin: 'com.android.library'

android {
    compileSdkVersion safeExtGet('compileSdkVersion', 26)
    buildToolsVersion safeExtGet('buildToolsVersion', '26.0.3')

    defaultConfig {
        minSdkVersion safeExtGet('minSdkVersion', 16)
        targetSdkVersion safeExtGet('targetSdkVersion', 22)
        versionCode 1
        versionName "1.0"
    }
    lintOptions {
        abortOnError false
    }
}

repositories {
    mavenCentral()
}

dependencies {
    compile 'com.facebook.react:react-native:+'
}
safaiyeh commented 4 years ago

I have forked the repo here: https://github.com/safaiyeh/react-native-cookie-store We can create issues and PRs there to continue the development of the project.