search

joefitzgerald / go-plus

An Enhanced Go Experience For The Atom Editor
https://atom.io/packages/go-plus
Other
1.51k stars 129 forks source link

Confusing error message on save. #1075

Open idthings opened 3 years ago

idthings commented 3 years ago

I am running 'test on save'. My tests run, the output appears in the Output pane. But the Output pane then refreshes and I get:

test timed out after 10000 ms

The timing felt a bit 'async', but I had trouble figuring out which test was running asynchronously. Increasing the tests timeout didn't make a difference.

Then I increased the compile timeout, from 10000 to 90000. This fixed the problem, and the Output pane finished with 'Done'.

I had a look at the build code section, and see my problem. The logic here formats the error string. If hasTests then the build tool name is set to 'test'.

https://github.com/joefitzgerald/go-plus/blob/0192d4719894d347e8f0cbc1826031fbcf49b002/lib/build/builder.js#L98

I think it would be much better if this was changed to something like:

compile timed out after 10000 ms

I don't have a js/Atom dev env, otherwise I submit a PR.