search

joefitzgerald / go-plus

An Enhanced Go Experience For The Atom Editor
https://atom.io/packages/go-plus
Other
1.51k stars 129 forks source link

Switch To Use gometalinter #213

Closed soygul closed 8 years ago

soygul commented 9 years ago

https://github.com/alecthomas/gometalinter

Just seeking to understand if this is a popular tool with the community. Given that it normalizes output from all known linters, can make linter editor integrations less manual.

joefitzgerald commented 9 years ago

Indeed. I think gometalinter is great. I am going to be revisiting the way we run all the tools we use and integrate with https://github.com/atomlinter/linter. As part of this, I will look into the use of gometalinter.

soygul commented 9 years ago

:+1:

rtyer commented 9 years ago

:+1:

adamclerk commented 8 years ago

:thumbsup:

santagada commented 8 years ago

Great, have messages integrated with the line of the problem is way better than having them on a tool box, and the metalinter is the way to go for performance and completeness reasons.

Can other people send pull requests for this or is anyone active in fixing this?

steelbrain commented 8 years ago

For the DIY people on here, it's super-simple to write a linter, see https://github.com/atom-community/linter/wiki/Linter-API and https://github.com/atom-community/linter/wiki/Migrating-to-the-new-API

joefitzgerald commented 8 years ago

This is pending a rewrite of the core runtime detection in https://github.com/joefitzgerald/go-runtime, so that we don't end up with a litany of different ways this is done. While it's trivial to write a linter it is very non trivial to do so in a way that a user has a zero configuration experience based on their current environment. go-runtime will also pave the way for gb and the GO15VENDOREXPERIMENT.

santagada commented 8 years ago

Thank you @steelbrain I will look into that. @joefitzgerald go-runtime doesn't look very promising seeing that it hasn't been any commits for 5 months right? Is there anything we can help you with that then?

joefitzgerald commented 8 years ago

@santagada it's because I haven't pushed the code that I have locally. For a period of time I was blocked on waiting for package-sets to be included in core (as I was the committer) but recently I decided to move ahead without package-sets as its such a large piece of work it will take time to ship. I will push new code there tomorrow, and I'd welcome the assistance.

santagada commented 8 years ago

@joefitzgerald any news?

mishak87 commented 8 years ago

Any progress? Linter API evolved quite a bit and maybe writing separate package for gometaliner would be best way to go.

joefitzgerald commented 8 years ago

Yep. https://atom.io/packages/gometalinter-linter.

mishak87 commented 8 years ago

@joefitzgerald Sorry I must have missed it :smile:. I promise I will do a lot of user testing.

AlbinOS commented 8 years ago

Hello,

I'm using gometalinter and goplus mainly for the autocompletion and the auto formatting capabilities. It works great but a little bit cumberstone to configure. Since you both maintain those packages, do you intend to use gometalinter as the provider for goplus ? Or to include autocompletion and autoformat capabilities to gometalinter ?

Thanks a lot for the great work !

joefitzgerald commented 8 years ago

@AlbinOS, yes, gometalinter-linter will replace built-in listing functionality. Autocomplete will be done via autocomplete-go, and formatting will be done via another package too.

joefitzgerald commented 8 years ago

This was shipped in go-plus v4.0.0. Please update to go-plus v4.1.0.