search

joefitzgerald / go-plus

An Enhanced Go Experience For The Atom Editor
https://atom.io/packages/go-plus
Other
1.51k stars 129 forks source link

win32 path issue #312

Closed kdar closed 8 years ago

kdar commented 8 years ago

Looking at the code, for win32 it checks for env.Path and every other OS it checks for env.PATH. On my system (win7), it's PATH. When I modify this code to use PATH instead it works. Otherwise goplus can't find my go installation.

Anyone else have this issue?

zmb3 commented 8 years ago

I use go-plus on windows all the time and never have a problem detecting my Go installation

kdar commented 8 years ago

Yea, I haven't had a problem until yesterday, and then changing the code as I mentioned above fixed it.

kumarharsh commented 8 years ago

But Windows is case-insensitive...

joefitzgerald commented 8 years ago

@kumarharsh, yes the file system is sometimes case in-sensitive but node's case sensitive when it comes to environment variable key names (I.e. Ignore the value of path; accessing process.env.PATH when you've set the key as Path will result in no value being found.