search

joefitzgerald / packer-windows

Windows Packer Templates
MIT License
1.63k stars 1.12k forks source link

Added atlas push support #167

Closed MOZGIII closed 8 years ago

MOZGIII commented 9 years ago

When pushing to atlas use gitignore to track ignored files and not load them

joefitzgerald commented 9 years ago

Does this play nice if someone is not using Atlas?

MOZGIII commented 9 years ago

It only matters if you ever use packer push comand, hich is afaik used only with atlas. So, I guess, it does. For a local build it does not matter.

senglin commented 9 years ago

@MOZGIII I could never get packer push to automatically build and register the vbox file in atlas. Are the configurations made sufficient for anyone to push to Atlas? If there still needs or other configuration (i.e. token, setting environment variables), it would be nice to have commented examples within the script.

MOZGIII commented 9 years ago

It's just a tiny bit of improvement for atlas support. By default it tries to upload all files, including isos and packer_cache, which are bigger than 5gb, which is maximum upload allowed by atlas.

To provide full support we probably need to add atlas post_processors, however I don't have a settled idea on how to implement it public-repo-friendly way, cause besides token, which is used from the environment by default (which is ok), there is also atlas vagrant repo name, which includes particular username, and that does not allow for easy sharing.

PS: I haven't used atlas much, just tried to use push, unsuccessfully, noticed the 5gb upload limitation, and decided that fixing jsons would be a good thing. I was going to initially add a custom ignored directories list, but vcs ignore is neat and fits well.

sneal commented 8 years ago

Closing this, but I'll merge it into #200.

MOZGIII commented 8 years ago

Great!