search

joefitzgerald / packer-windows

Windows Packer Templates
MIT License
1.63k stars 1.12k forks source link

fix vbox guest tool silent installation on windows due to pending certs #247

Closed lmayorga1980 closed 6 years ago

lmayorga1980 commented 6 years ago

I had issues deploying the VBoxGuest tools with VBox 5.1.22 and this fixed the issue.

Flauschbaellchen commented 6 years ago

I fixed this by adding

cmd /c for %%i in (C:\Windows\Temp\virtualbox\cert\vbox*.cer) do C:\Windows\Temp\virtualbox\cert\VBoxCertUtil add-trusted-publisher %%i --root %%i

instead of your changes on the same line. This is also the preferred method described in "4.2.1.3. Unattended Installation" of the documentation.

DanielKinsman commented 6 years ago

Issue is #230, there is also another PR fixing this in a different way at #229.

StefanScherer commented 6 years ago

This PR looks better as we do not have to update the certs every x years in this repo. I‘ll try to find some time to test in the nect days and merge a fix.

StefanScherer commented 6 years ago

LGTM. We can also get rid of oracle-cert.cer.

Flauschbaellchen commented 6 years ago

@StefanScherer I've opened another PR including the line from my first comment. IMO it would be much cleaner, do respect changes like adding/removing certs and is also described as the preferred solution within the virtualbox documentation.