joeharrison714
commented
8 years ago Not sure why but I am just seeing this. I am checking it out now!
Closed johnpreed closed 3 years ago
joeharrison714
commented
8 years ago Not sure why but I am just seeing this. I am checking it out now!
joeharrison714
commented
8 years ago Hey John, did you mean to include all the commits that are in this pull request? I would like to pull in the WithBrowserNavigationMode change but I saw some other things like vertical table and some bug fixes. Wasn't sure if that was intentional. I'd like to pull them in too if they apply to everyone. Thanks, Joe
johnpreed
commented
8 years ago Yeah you can totally pull everything. I've been using my latest commit for quite a while now with no problems
Sent from my iPhone
On Jan 27, 2016, at 7:35 AM, Joe Harrison notifications@github.com wrote:
Hey John, did you mean to include all the commits that are in this pull request? I would like to pull in the WithBrowserNavigationMode change but I saw some other things like vertical table and some bug fixes. Wasn't sure if that was intentional. I'd like to pull them in too if they apply to everyone. Thanks, Joe
— Reply to this email directly or view it on GitHub.
joeharrison714
commented
8 years ago Cool... there are conflicts that need to be resolved. Any chance you could do that so I can just accept the pull request?
On Wed, Jan 27, 2016 at 11:42 AM, johnpreed notifications@github.com wrote:
Yeah you can totally pull everything. I've been using my latest commit for quite a while now with no problems
Sent from my iPhone
On Jan 27, 2016, at 7:35 AM, Joe Harrison notifications@github.com wrote:
Hey John, did you mean to include all the commits that are in this pull request? I would like to pull in the WithBrowserNavigationMode change but I saw some other things like vertical table and some bug fixes. Wasn't sure if that was intentional. I'd like to pull them in too if they apply to everyone. Thanks, Joe
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHub https://github.com/joeharrison714/MVCGrid.Net/pull/24#issuecomment-175736663 .
johnpreed
commented
8 years ago sure thing! i'll take a look and let you know when it's ready
Date: Wed, 27 Jan 2016 09:45:23 -0800 From: notifications@github.com To: MVCGrid.Net@noreply.github.com CC: johnpreed@hotmail.com Subject: Re: [MVCGrid.Net] Added BrowserNavigationMode (#24)
Cool... there are conflicts that need to be resolved. Any chance you could
do that so I can just accept the pull request?
On Wed, Jan 27, 2016 at 11:42 AM, johnpreed notifications@github.com
wrote:
Yeah you can totally pull everything. I've been using my latest commit for
quite a while now with no problems
Sent from my iPhone
On Jan 27, 2016, at 7:35 AM, Joe Harrison notifications@github.com
wrote:
Hey John, did you mean to include all the commits that are in this pull
request? I would like to pull in the WithBrowserNavigationMode change but I
saw some other things like vertical table and some bug fixes. Wasn't sure
if that was intentional. I'd like to pull them in too if they apply to
everyone.
Thanks,
Joe
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/joeharrison714/MVCGrid.Net/pull/24#issuecomment-175736663
.
— Reply to this email directly or view it on GitHub.
johnpreed
commented
8 years ago Hey Joe, I think it should be all set.. i'm still getting used to github desktop -- pretty sure i did it right. have a look and let me know if i screwed it up :)
From: johnpreed@hotmail.com To: reply@reply.github.com; mvcgrid.net@noreply.github.com Subject: RE: [MVCGrid.Net] Added BrowserNavigationMode (#24) Date: Wed, 27 Jan 2016 14:06:13 -0800
sure thing! i'll take a look and let you know when it's ready
Date: Wed, 27 Jan 2016 09:45:23 -0800 From: notifications@github.com To: MVCGrid.Net@noreply.github.com CC: johnpreed@hotmail.com Subject: Re: [MVCGrid.Net] Added BrowserNavigationMode (#24)
Cool... there are conflicts that need to be resolved. Any chance you could
do that so I can just accept the pull request?
On Wed, Jan 27, 2016 at 11:42 AM, johnpreed notifications@github.com
wrote:
Yeah you can totally pull everything. I've been using my latest commit for
quite a while now with no problems
Sent from my iPhone
On Jan 27, 2016, at 7:35 AM, Joe Harrison notifications@github.com
wrote:
Hey John, did you mean to include all the commits that are in this pull
request? I would like to pull in the WithBrowserNavigationMode change but I
saw some other things like vertical table and some bug fixes. Wasn't sure
if that was intentional. I'd like to pull them in too if they apply to
everyone.
Thanks,
Joe
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/joeharrison714/MVCGrid.Net/pull/24#issuecomment-175736663
.
— Reply to this email directly or view it on GitHub.
Now supports both pushState and replaceState when performing an action on the grid by defining the BrowserNavigationMode. Defaults to pushState, which was the original implementation. if you only want to preserve latest action on your grid, then set .WithBrowserNavigationMode(BrowserNavigationMode.PreserveLatestGridAction)