Open Ivan-L opened 7 years ago
Would you be able to submit a PR for this? Otherwise, I can probably look into this sometime next week.
On Jan 4, 2017 11:14 AM, "Ivan-L" notifications@github.com wrote:
Hi there,
When an AggregateException or TargetInvocationException is thrown, the exception is logged as-is to Crashlytics. The real underlying cause of the exception, however, is lost because the inner exception(s) are not logged.
It would be very useful if AggregateExceptions and TargetInvocationExceptions are stripped away so that the real causes can be logged. For example, if an AggregateException occurs its InnerExceptions property should be examined and potentially multiple errors should be logged to Crashlytics. Note that the InnerExceptions might contain AggregateExceptions as well, so Flatten() would most likely need to be called on the AggregateException prior to this. Similarly for TargetInvocationException, its InnerException should be reported, if it is present.
Please let me know your thoughts on this?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joeisapro/MonoTouch.Fabric/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHUjq8aXZ0ZVf7hynmRx4cg8wg0hs5vks5rO8VUgaJpZM4LayXJ .
No problem, I will start a PR so we can discuss there.
PR #10 is open for discussion.
Hi there,
When an AggregateException or TargetInvocationException is thrown, the exception is logged as-is to Crashlytics. The real underlying cause of the exception, however, is lost because the inner exception(s) are not logged.
It would be very useful if AggregateExceptions and TargetInvocationExceptions are stripped away so that the real causes can be logged. For example, if an AggregateException occurs its InnerExceptions property should be examined and potentially multiple errors should be logged to Crashlytics. Note that the InnerExceptions might contain AggregateExceptions as well, so Flatten() would most likely need to be called on the AggregateException prior to this. Similarly for TargetInvocationException, its InnerException should be reported, if it is present.
Please let me know your thoughts on this?