Document AWS resources that are not in the CFN Stack

joejulian / container-aws-createmachines

A container for creating aws ec2 machines for cluster-api

Apache License 2.0

1 stars 3 forks source link

Open philoserf opened 6 years ago

philoserf commented 6 years ago

The EC2 key pair is not part of the CFN stack, and so, is not destroyed when the stack is destroyed.

It and any other resources created should be documented so that they can be cleaned up when the stack is destroyed.

joejulian commented 6 years ago

The one time you don't submit a PR when you spot these kinds of issues. lol. This is an easy merge. :)

philoserf commented 6 years ago

Yeah. Didn't know if there were more AND I was moving fast building and destroying.

joejulian commented 5 years ago

Actually, I'm going to reopen this. I agree with this issue and hope to get to it next week.