search

joekaiser / practicalities

1 stars 3 forks source link

Pre-Chewed Food #31

Open thecodewarrior opened 8 years ago

thecodewarrior commented 8 years ago

Adds Pre-Chewed food and the ability to feed the player by piping pre chewed food into the player interface.

joekaiser commented 8 years ago

Away on vacation. Will look when I get back wednesday

joekaiser commented 8 years ago

oh! I have internet at the vacation place. I didn't think I would. Going to look at this now. Looks promising

joekaiser commented 8 years ago

This is a pretty good. There are a few bugs, but I don't think it will stop the merge. Going to grab a bite to eat then I will merge this in and log a few bugs. Maybe I can fix them tonight to :)

the biggest one is that is the new fluid doesn't seem to work well with buckets. For example, take a bucket of PCF and put it in a fluid transposer. I can't get it to take the bucket. I can pipe it in from the Masher, but I can't empty it into a bucket using the fluid transposer either.... i'll file the bugs and see if I can fix them

thecodewarrior commented 8 years ago

I might have forgotten to register it as a fluid container? maybe?

joekaiser commented 8 years ago

I'm not sure. It doesn't seem to be behaving as other fluids are. If you don't have it, add the Thermal Expansion-dev files to your test instance and make the pre-chewed food interact with the fluid transposer. You will see the weirdness I am talking about.

ThermalExpansion-dev ThermalFoundation-dev

joekaiser commented 8 years ago

Also, using fluid tanks I could put the pre-chwed in using a bucket, but I wasn't able to take any out

thecodewarrior commented 8 years ago

I think it's all because I never registered it as a fluid container. I'll get on that.

On Tuesday, December 15, 2015, Joe notifications@github.com wrote:

Also, using fluid tanks I could put the pre-chwed in using a bucket, but I wasn't able to take any out

— Reply to this email directly or view it on GitHub https://github.com/joekaiser/practicalities/pull/31#issuecomment-164842498 .