search

joekiller / jruby-kafka

Apache License 2.0
71 stars 52 forks source link

Switch from jbundler to lock_jar #13

Closed pangloss closed 9 years ago

pangloss commented 9 years ago

I switched all of my libraries over to lock_jar the other day because it's the only JRuby maven integration that I know of that just works.

For an example of how I set it up in one project, see this commit.

If you're ok with the change, I'll make a pull request.

joekiller commented 9 years ago

I like jbundler right now because the logstash guys use it as well. That being said, I'm all for easier integrations. Feel free to make a PR but I'll have to review it in scope with what else is using the project.

joekiller commented 9 years ago

Hi I decided to use https://github.com/mkristian/jar-dependencies as it is more in line with how the logstash/elasticsearch guys are integrating jars into their libraries, ie https://github.com/logstash-plugins/logstash-output-elasticsearch. Thank you for your feedback and support.