joekiller / jruby-kafka

Apache License 2.0
71 stars 52 forks source link

Add serializer.encoding to producer's KNOWN opts #14

Closed talevy closed 10 years ago

talevy commented 10 years ago

I would like to update the StringEncoder's encoding without receiving a Warning message about serializer.encoding not being a known config option

joekiller commented 10 years ago

I see serializer.class in the options but no serializer.encoding. could you point me to that option?

I usually look at: http://kafka.apache.org/documentation.html

talevy commented 10 years ago

It seems to be an extra optional configuration specific to the StringEncoder https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/serializer/Encoder.scala#L43-L44

joekiller commented 10 years ago

Ah yes. We discussed this here as well: https://github.com/elasticsearch/logstash/pull/1749 On Nov 10, 2014 6:17 PM, "Tal Levy" notifications@github.com wrote:

It seems to be an extra optional configuration specific to the StringEncoder

https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/serializer/Encoder.scala#L43-L44

— Reply to this email directly or view it on GitHub https://github.com/joekiller/jruby-kafka/pull/14#issuecomment-62474415.

joekiller commented 10 years ago

Thank you @talevy.

talevy commented 10 years ago

no, thank you @joekiller!