search

joekiller / jruby-kafka

Apache License 2.0
71 stars 52 forks source link

Namespace conflicts #49

Closed guyisra closed 8 years ago

guyisra commented 8 years ago

Hey,

A lot of kafka related gems use the namespace Kafka

Would it be possible to rename the namespace of this gem to something else so it will be more unique (like JKafka or something)

thanks

joekiller commented 8 years ago

What conflict are you.experiencing? I'm somewhat less inclined to indulge this as this project has been going since 2013 and is the only JRuby Kafka platform that I know of.

guyisra commented 8 years ago

Kafka::Consumer is also used in https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/consumer.rb

While I understand and think that the later gem should rename the namespace (I also requested it there) I opened it here to try and solve this at either end :)

joekiller commented 8 years ago

Yeah I just found their project. It's a native Ruby implementation so while there is some potential for conflict I'd expect each gem to have different target audiences.

Trying something out? Getting on the Kafka train? Send me an email if you have questions. On Mar 23, 2016 8:28 AM, "Guy" notifications@github.com wrote:

Kafka::Consumer is also used in https://github.com/zendesk/ruby-kafka/blob/master/lib/kafka/consumer.rb

While I understand and think that the later gem should rename the namespace (I also requested it there) I opened it here to try and solve this at either end :)

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/joekiller/jruby-kafka/issues/49#issuecomment-200327777