Destroy underlying socket when connect fails

joekrill / elk-client

Elk M1 client library for Node.JS

https://joekrill.github.io/elk-client/

MIT License

1 stars 1 forks source link

Destroy underlying socket when connect fails #2

Closed joekrill closed 5 years ago

joekrill commented 5 years ago

If an ElkSocketConnection.connect() call fails, the socket needs to be destroyed explicitly because the failure may have been called by our own timeout -- in which case it could still eventually end up connecting at some point and the connection would be left open with no one knowing about it.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 38

11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 97.531%

Totals
Change from base Build 2:	0.1%
Covered Lines:	480
Relevant Lines:	480

💛 - Coveralls

joekrill commented 5 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: