joel-foo / pe

0 stars 0 forks source link

DG: inconsistent ways of showing how constructor is called for edit command. #20

Open joel-foo opened 11 months ago

joel-foo commented 11 months ago
soc-pe-bot commented 11 months ago

Team's Response

Does not hinder the ability of the developer to understand the diagram.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While the label for the second constructor is fine, it still does not mean that there is no error with the first constructor label. The inconsistency in labelling for a constructor call might make the developer think they are two different types of methods/confuse the developer. I have agreed this be downgraded to a 'veryLow' severity, as it is a largely cosmetic issue.

The first constructor to EditPersonDescriptor has the "new" label, which is not consistent with how the label for constructor should be shown in a sequence diagram: (picture below is from CS2103T website)

Screenshot 2023-11-21 at 1.47.39 PM.png


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]