search

joel-foo / pe

0 stars 0 forks source link

DG: planned enhancement is rather vague. #24

Open joel-foo opened 11 months ago

joel-foo commented 11 months ago

A planned enhancement should only target one issue, if it is the command message pertaining to IC, then the title of the enhancement should be "Clearer error message for invalid NRIC" as it needs to be specific.

Screenshot 2023-11-17 at 5.37.11 PM.png

nus-pe-script commented 11 months ago

Team's Response

While this is a valid issue, we believe this might have led to multiple similar paragraphs - which would make it repetitive.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: - This issue is in scope. Prof mentioned in one of the issues on the forum that the planned enhancement cannot be too broad - i.e. if there are multiple enhancements for different error messages, there needs to be a separate planned enhancement for each error message.