search

joel16 / 3DSident

PSPident clone for 3DS
zlib License
284 stars 25 forks source link

colors and refresh information #2

Closed SegFault42 closed 8 years ago

SegFault42 commented 8 years ago
joel16 commented 8 years ago

I'd like to merge this, but that indentation (IMO) is horrible lol. I know my indentation looked pretty crappy on github, but that's because Notepad++ messes with the formatting sometimes. It looks well indentened on my notepad, but doesn't when I push it to git.

If you can revert to my indentation: const char getModel() -> const char \ getModel() and not mess with the colors or the title aligment I'd be happy to merge.

Thank you for fixing certain indentation issues though. I blame notepad++ for that. Might come off as an asshole asking you to fix these, but it's because I'm trying to retain the same style the original PSPident and PS2ident uses.

joel16 commented 8 years ago

On a second thought, I might keep the colors because it goes easy on the eyes and makes things more readable, however if you can change the other things I requested I'll gladly merge this.

SegFault42 commented 8 years ago

ok, you want to keep the title alignement ? And what can i do for the variable indentation and declaration ?

joel16 commented 8 years ago

Well function declarations should be just one space: for example you have int vaPrint(char *format, ...) but what I mean is like int vaPrint(char *format, ...) (just one space after the function type.) Also I use 'char * str' and not 'char *str'. It's kind of like an ocd thing for me.

also this bit

if (region < 7)
        return regions[region];
    else
        return regions[7];

Just a new line and one tab should be fine for indentation there.

local variables inside functions need to be indented properly as well. For example u8 screens = 0; should be u8 screens = 0; one space. Just do as much as you can, I'll fix the rest later :p

And yes, I'd like it if you reverted the centered alignment back to left align for the title and the "press to exit" string.

Thanks for understanding!

SegFault42 commented 8 years ago

i think it's good right now. Sorry for my indentation ^^.

joel16 commented 8 years ago

No problem, looks good. I'll merge.

SegFault42 commented 8 years ago

thank you