search

joel16 / SwitchIdent

An identity tool for the Nintendo Switch
GNU General Public License v3.0
77 stars 14 forks source link

Battery voltage state? #5

Closed maciak closed 6 years ago

maciak commented 6 years ago

Hi, For me it shows max77620_sd3 as a battery voltage state. I believe it's not correct. I'm using version compiled by me from new commit 816ef0a.

joel16 commented 6 years ago

Hmm I'm not sure but I'm using the data from switchbrew: https://switchbrew.org/wiki/PCV_services

What makes you think it isn't correct?

maciak commented 6 years ago

Well I just thought that battery voltage state should show astuall state preferably in mV and not the name of the chip.

joel16 commented 6 years ago

That doesn't return the actual voltage.

maciak commented 6 years ago

Than you probably should change the name as it's a bit confusing :)

joel16 commented 6 years ago

Oh right, that's why it's displayed as "Voltage state", if I was talking about actual voltage I would've just made it display "Voltage:"

maciak commented 6 years ago

that's fair enough :)