joel74 / POSH-F5-BIGIP

A set of PowerShell modules for working with F5 BIGIP devices using the iControlREST API
14 stars 8 forks source link

Document Remove-PoolMember requires port #6

Closed spuder closed 6 years ago

spuder commented 6 years ago

I couldn't get Remove-PoolMember to work. It was not returning any errors, but wasn't removing the member.

Remove-PoolMember -PoolName 'foo' -Partition 'Common' -Name 'bar' -Verbose

It would be good to document that the 'Name' attribute requires that the port be part of the name

wrong

-Name 'bar'

correct

-Name 'bar:80'
joel74 commented 6 years ago

Hi, I believe you're thinking about nodes, not pool members. Pool members always have a port specified as part of their name. This allows for the same node to service different pools on different ports. But that aside, you're right - Remove-PoolMember should probably throw a 'member not found' error when you try to remove a pool member that it can't locate.

spuder commented 6 years ago

Yes. That was the mistake. A warning 'member $member not found' would be helpful.

joel74 commented 6 years ago

Ok, pull request made. Please review when you get a chance. Thanks.

joel74 commented 6 years ago

Pull request merged. Closing this issue.