Open mhansen opened 2 years ago
Looks like the DISTRO is hardcoded in androdeb
.
I think this patch should fix it?
> git diff
diff --git a/androdeb b/androdeb
index a2ee65b..60c5566 100755
--- a/androdeb
+++ b/androdeb
@@ -63,6 +63,7 @@ case $key in
--sshpass) SSHPASS="sshpass -p$2"; shift || true; shift || true; ;;
--build-image) BI=1; BUILD_IMAGEF=$2; SKIP_DEVICE=1; DOWNLOAD=0; shift || true; shift || true; ;;
--debug) set -x; shift || true; ;;
+ --distro) DISTRO="$2"; shift || true; shift || true; ;;
*) c_error "Unknown option ($1)"; usage; ;;
esac
done
I no longer maintain it but I'm happy to accept PRs. Could you send me a PR for this?
Absolutely — will send them next week when I’m back at work. Heads up I may have a few more PRs around moving from installing python2 to python3, so that new debian works.
Appreciate it!
On Fri, 24 Sep 2021 at 21:04, Joel @.***> wrote:
I no longer maintain it but I'm happy to accept PRs. Could you send me a PR for this?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joelagnel/adeb/issues/43#issuecomment-926539233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZYOJKPI7NZ52TW2DVPLLUDRLMDANCNFSM5EVFTS5A .
Before I send a bunch of PRs, I might ask: do you know of an easier way than this project to run bpftrace on Android? (I'm wondering/hoping if the lack of maintenance may be connected to a better way emerging that obsoletes this? e.g. can we copy a statically linked bpftrace to Android now?)
Just linking up some issues: https://github.com/iovisor/bpftrace/issues/342#issuecomment-517353729 discusses some constraints around statically linking bpftrace -- the problem seems to be that bpftrace compiles programs with LLVM and LLVM is huge.
I no longer maintain it but I'm happy to accept PRs. Could you send me a PR for this?
https://github.com/joelagnel/adeb/pull/48 Can you review this PR?
Before I send a bunch of PRs, I might ask: do you know of an easier way than this project to run bpftrace on Android? (I'm wondering/hoping if the lack of maintenance may be connected to a better way emerging that obsoletes this? e.g. can we copy a statically linked bpftrace to Android now?)
This project can run bpftrace directly on Android: https://github.com/facebookexperimental/ExtendedAndroidTools
Hi there, a little error I got when I tried to upgrade from debian buster (now superseded by bullseye).
This was in order to get the latest version of
bpftrace
which should contain a fix for https://github.com/iovisor/bpftrace/issues/515.