search

joelalejandro / ember-data-patch-persistance

An addon that allows saving partial models with HTTP PATCH.
MIT License
9 stars 1 forks source link

Possible beta-19.1 issue - createSnapshot #1

Open kalebdf opened 9 years ago

kalebdf commented 9 years ago

I installed the plugin and attempted to use myModel.patch() and receive the following error: internalModel.createSnapshot is not a function. myModel is a simple model with 3 attributes at the moment.

DEBUG: Ember      : 1.12.0
DEBUG: Ember Data : 1.0.0-beta.19.1

The plugin works for with beta.17; however, with beta.19.1 there are quite a few changes especially around the scheduleSave(...) and InternalModel. The InternalModel has a createSnapshot method which seems to be working fine inside the myModel.save().

Thanks for the help.

joelalejandro commented 9 years ago

@kalebdf the issue-1 branch should cover this issue. Care to try changing your package.json file to use it? If everything's OK, I'll close this issue merging the PR.

kalebdf commented 9 years ago

@joelalejandro The DS.InternalModel does not have a reopen.

Uncaught TypeError: DS.default.InternalModel.reopen is not a function

joelalejandro commented 9 years ago

Right, because it's not a typical Ember.Object. What was I thinking, lol? I'll have another look at it.

Joel A. Villarreal Bertoldi Diseñador gráfico / Desarrollador Tel.: +54 9 (351) 6 - 710 - 728

2015-06-11 1:57 GMT-03:00 Kaleb Fulgham notifications@github.com:

@joelalejandro https://github.com/joelalejandro The DS.InternalModel does not have a reopen.

Uncaught TypeError: DS.default.InternalModel.reopen is not a function

— Reply to this email directly or view it on GitHub https://github.com/joelalejandro/ember-data-patch-persistance/issues/1#issuecomment-110999158 .

indvinoth commented 8 years ago

Hi @joelalejandro , is this issue closed, because I am getting the same error while trying to patch my model. Thanks in advance

joelalejandro commented 8 years ago

Vinoth, unfortunately I didn't fix it back then for beta-19.1, and since then Ember Data has progressed so much that this addon is a bit obsolete by now. I'll see if I can bring it up-to-date, but I don't have a timeline set for this.

El lun., 18 de jul. de 2016 a la(s) 12:29, Vinoth Kumar < notifications@github.com> escribió:

Hi @joelalejandro https://github.com/joelalejandro , is this issue closed, because I am getting the same error while trying to patch my model. Thanks in advance

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joelalejandro/ember-data-patch-persistance/issues/1#issuecomment-233363829, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHQgdal0WTsxDP3hCo9w-iV_-mbWg3hks5qW5vfgaJpZM4E-19G .

Joel Alejandro Villarreal Bertoldi Desarrollador de software / Diseñador gráfico

GitHub / Twitter: @joelalejandro Tel.: (351) 671-0728

indvinoth commented 8 years ago

Yeah I agree and by the way thanks for your quick response :)