search

joelberkeley / spidr

Accelerated machine learning with dependent types
Apache License 2.0
72 stars 4 forks source link

[ compat ] adjust to upstream changes #381

Closed stefan-hoeck closed 7 months ago

stefan-hoeck commented 7 months ago

Spidr no longer builds against the latest Idris2 HEAD, because spidr has its own implementation of (++) for Data.List.Quantifiers.All, which has been added to base recently. This PR removes spidr's version of (++), as it is no longer needed.

stefan-hoeck commented 7 months ago

About the failing CI tests: These use the latest docker builds from pack, which do not yet include the latest version of the Idris compiler, because no new pack collection are generated as long as part of the collection fails to build. They are therefore expected to fail here.

Therefore, if possible, the issue addressed in this PR should be fixed soonish, because otherwise we won't get new pack-db nightlies.

joelberkeley commented 7 months ago

how do I test my changes? can I install the latest idris version with pack itself? pack switch latest and pack upgrade-db don't work. I'm working in a pack docker container since I can't install pack on my machine

at the moment I'm unable to replicate the issue, likely because I don't have the latest version of Idris. Is there a pack version with the latest Idris, or not because it's blocked on this change?

joelberkeley commented 7 months ago

i'm currently trying pack switch HEAD, looks promising

joelberkeley commented 7 months ago

I've merged this change in a separate PR so I could do it tonight (I needed to move to building against HEAD too and didn't see any way to edit your PR)