joelbrs / bank.com.br

https://bank.joelf.tech
3 stars 0 forks source link

Idempotency redis impl #44

Open joelbrs opened 3 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bank-web.com.br ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 2:29pm
bank.com.br.server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 2:29pm
coderabbitai[bot] commented 3 months ago

Walkthrough

As mudanças introduzem a integração do Redis na arquitetura do aplicativo, melhorando a configuração do ambiente, a criação de transações e a gestão de contextos. Novas variáveis de ambiente para o Redis foram adicionadas, junto com um arquivo docker-compose para serviços de desenvolvimento. O código foi refinado para eliminar a necessidade de chaves idempotentes, simplificando a lógica de criação de transações e aprimorando a estrutura de testes.

Changes

Arquivo Resumo das mudanças
apps/server/.env.example Adição das variáveis de ambiente REDIS_HOST, REDIS_PORT e REDIS_PASSWORD; NODE_ENV permanece inalterado.
apps/server/docker-compose.dev.yml Introdução de configuração para serviços MongoDB e Redis em um ambiente de desenvolvimento, com comandos, health checks e volumes configurados.
apps/server/package.json Adição da dependência ioredis na versão ^5.4.1 para suporte ao Redis.
apps/server/src/config/environment.ts Expansão do esquema de configuração para incluir REDIS_HOST, REDIS_PORT e REDIS_PASSWORD, com NODE_ENV agora aceitando "test".
apps/server/src/get-context.ts Remoção da propriedade idempotentKey da interface ContextVars e ajuste da função getContext para simplificação.
apps/server/src/modules/transaction/__test__/create-transaction.spec.ts Reestruturação dos testes para CreateTransactionMutation, focando em validação de fundos e introduzindo novos casos de teste para duplicatas e contas inexistentes.
apps/server/src/modules/transaction/fixtures/create-transaction.ts Remoção da atribuição de idempotentKey na função createTransaction, simplificando o processo de criação de transações.
apps/server/src/modules/transaction/mutations/create-transaction.ts Alteração da lógica de idempotência para geração de chave baseada em hash, incluindo melhorias no tratamento de erros.
apps/server/src/modules/transaction/transaction-model.ts Remoção do idempotentKey do tipo Transaction e do esquema Mongoose, simplificando a estrutura do modelo.
apps/server/src/redis.ts Criação de um arquivo para gerenciar a conexão com o Redis, utilizando a biblioteca ioredis e variáveis de ambiente para configuração.

Sequence Diagram(s)

sequenceDiagram
    participant App as Aplicação
    participant Redis as Redis
    participant Mongo as MongoDB

    App->>Redis: Solicita conexão
    Redis-->>App: Retorna cliente Redis

    App->>Mongo: Cria transação
    Mongo-->>App: Retorna ID da transação

    App->>Redis: Gera chave de idempotência
    Redis-->>App: Armazena estado da transação com expiração

Poem

🐰 "Em um bosque florido, eu me alegro a saltar,
Com Redis agora, tudo vai acelerar!
Transações mais leves, sem chave a pesar,
No mundo digital, vamos juntos dançar!
Um brinde ao progresso, vamos celebrar!" 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.