search

joelburget / react-haskell

React bindings for Haskell
MIT License
351 stars 26 forks source link

Fix hackage build #3

Closed joelburget closed 9 years ago

joelburget commented 9 years ago

The hackage build is currently broken, presumably because haste-specific stuff breaks haddock. I think this can be fixed with liberal use of CPP macros.

jeremyjh commented 9 years ago

Oh this is another good reason for #4 :)

joelburget commented 9 years ago

I pushed the updated docs on Tuesday, but hackage still says "Docs pending, build status unknown". Seems suspicious but I guess I'll continue to wait.

jeremyjh commented 9 years ago

I think it's not going to build because haste-compiler isn't for some reason.

On Sunday, December 14, 2014, Joel Burget notifications@github.com wrote:

I pushed the updated docs on Tuesday, but hackage still says "Docs pending, build status unknown" http://hackage.haskell.org/package/react-haskell-1.2.0.0. Seems suspicious but I guess I'll continue to wait.

— Reply to this email directly or view it on GitHub https://github.com/joelburget/react-haskell/issues/3#issuecomment-66919257 .

joelburget commented 9 years ago

Fixed! Used the hackage-docs.sh script.

joelburget commented 9 years ago

Interesting / weird note. Cabal haddock always barfs on the first line (pragma comment) of React.Imports. I delete that line and things work fine. Why? No idea. Makes no sense.