joelbutcher / laravel-googleads

Laravel Service Provider for the Google Ads Client OAuth2 Wrapper
MIT License
10 stars 3 forks source link

V13 deprecated #8

Closed dominikraff closed 9 months ago

dominikraff commented 9 months ago

Hello. can you change to v15 in your GoogleAds.php File? public function __construct( private string $clientId, private string $clientSecret, private string $developerToken, private int $sdkVersion = SupportedVersions::VERSION_13, private string $transportProtocol = 'rest', private ?LoggerInterface $logger = null, private string $logLevel = 'INFO' ) {

Regards, DOminik
joelbutcher commented 9 months ago

Wrong repo – joelbutcher/googleads is the one you're looking for :)

dominikraff commented 9 months ago

Sorry, will you change this there?

Von: Joel Butcher @.> Gesendet: Freitag, 9. Februar 2024 10:53 An: joelbutcher/laravel-googleads @.> Cc: dominikraff @.>; Author @.> Betreff: Re: [joelbutcher/laravel-googleads] V13 deprecated (Issue #8)

Wrong repo – joelbutcher/googleads https://github.com/joelbutcher/googleads is the one you're looking for :)

— Reply to this email directly, view it on GitHub https://github.com/joelbutcher/laravel-googleads/issues/8#issuecomment-1935624184 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGQCZYT43F77P4LGJM3MPOLYSXWWFAVCNFSM6AAAAABDA56MUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGYZDIMJYGQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AGQCZYRK6PWWNSOJOGNLMXDYSXWWFA5CNFSM6AAAAABDA56MUGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTTL5D7Q.gif Message ID: @. @.> >

joelbutcher commented 9 months ago

Please update your composer to use v7.0.0 of this package, which should use v8.0.0 of the base Google Ads SDK