Closed miguilimzero closed 11 months ago
@joelbutcher Sorry, but I could not find a relation between this feature flag and the multiple stacks available. I made the following changes:
createAccountOnFirstLogin
feature.createAccountOnFirstLogin
feature not enabledReleased v5.3.2 with this fix included, sorry for the slowness here – thanks for your work!
This pull request improves the new account registration handling. The current code has a duplicate code to handle that, and the logic gets slightly confusing.
Here is an example. Let's consider the flag
hasCreateAccountOnFirstLoginFeatures
is enabled:Current version:
/login
with social media, but the account already exists, and it's not connected./register
with social media but the account already exists, and it's not connected./potato
with social media, but the account already exists, and it's not connected.With the code refactoring, the first code snippet will handle every route case if the "create account from login" flag is enabled (not only login) and the second code snipped is removed. We are preserving the exact same logic here.