joelbutcher / socialstream

OAuth for Laravel, simplified.
https://docs.socialstream.dev
MIT License
433 stars 66 forks source link

[bug]: File connected-accounts-form.blade.php seems to have a deprecated variable #337

Closed Philrobots closed 8 months ago

Philrobots commented 8 months ago

Stack

Jetstream – Livewire

Package Version

5.4.2

Laravel Version

v10.0.0

Livewire Version

v.3.4.6

react Version

No response

Vue Version

No response

PHP Version

v.8.1.0

Problem description

At line 71, of the connected-accounts-form.blade.php

The value :

"$toggle('confirmingRemove')"

does not seems to exist anymore, it should be remove by :

"$toggle('confirmingAccountRemoval')"

   <x-slot name="footer">
                <x-secondary-button wire:click="$toggle('confirmingRemove')" wire:loading.attr="disabled">
                    {{ __('Cancel') }}
                </x-secondary-button>

                <x-danger-button class="ml-2" wire:click="removeConnectedAccount" wire:loading.attr="disabled">
                    {{ __('Remove Account') }}
                </x-danger-button>
            </x-slot>

Expected behavior

Should be :

 <x-slot name="footer">
                <x-secondary-button wire:click="$toggle('confirmingAccountRemoval')" wire:loading.attr="disabled">
                    {{ __('Cancel') }}
                </x-secondary-button>

                <x-danger-button class="ml-2" wire:click="removeConnectedAccount" wire:loading.attr="disabled">
                    {{ __('Remove Account') }}
                </x-danger-button>
            </x-slot>

Steps to reproduce

See below

Reproduction repository

Socialstream repository

Relevant log output

I tried to open a pull request but it looks like the repository is just readable
github-actions[bot] commented 8 months ago

Hey @Philrobots! We're sorry to hear that you've hit this issue. 💙

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Socialstream code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

Also, it doesn't look like you've provided much information on how to replicate the issue. Please edit your original post with clear steps we need to take.