search

joelbutcher / socialstream

OAuth for Laravel, simplified.
https://docs.socialstream.dev
MIT License
433 stars 66 forks source link

2FA enabled account skipping 2FA code sign-in when logging in with OAuth provider #346

Closed mystyq closed 7 months ago

mystyq commented 7 months ago

Stack

Jetstream – Livewire

Package Version

^6.0

Laravel Version

11

Livewire Version

No response

react Version

No response

Vue Version

No response

PHP Version

8.3.4

Problem description

2FA enabled account skips the 2FA code check when signing in with OAuth provider (google in my context)

Expected behavior

2FA enabled account should prompt for code before signing in using OAuth flow

Steps to reproduce

  1. Create account
  2. Enable 2FA
  3. Connect Google account with same email
  4. Log-out
  5. Log in with Google account

Reproduction repository

https://github.com/joelbutcher/socialstream

Relevant log output

No response

github-actions[bot] commented 7 months ago

Hey @mystyq! We're sorry to hear that you've hit this issue. 💙

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Socialstream code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.