joelbutcher / socialstream

OAuth for Laravel, simplified.
https://docs.socialstream.dev
MIT License
433 stars 66 forks source link

[6.x] Remove webmozart/assert package #352

Closed miguilimzero closed 7 months ago

miguilimzero commented 7 months ago

Summary

This pull request removes the webmozart/assert package. The package is used in only one file to throw InvalidArgumentException in some scenarios. Although these exceptions are never caught, the PR manually adds the exceptions with the exact same messages from the package.

The motivation for this PR is because the package is giving some strange conflict errors when trying to install vimeo/psalm with socialstream and webmozart/asset with an already composer.lock generated.

Manually adding vimeo/psalm to the project and deleting the composer.lock fixes the conflict. However, since this package's last commit was 2 years ago and is only being used in one single file, I personally don't see a reason to keep it.

Checklist

joelbutcher commented 7 months ago

However, since this package's last commit was 2 years ago and is only being used in one single file, I personally don't see a reason to keep it.

Which commit / package are you referring to here?

miguilimzero commented 7 months ago

@joelbutcher https://github.com/webmozarts/assert package. The last commit was on Jun 3, 2022.