search

joelbutcher / socialstream

OAuth for Laravel, simplified.
https://docs.socialstream.dev
MIT License
433 stars 66 forks source link

[6.x] fix auth when using a custom authentication pipeline in Fortify #379

Closed joelbutcher closed 1 month ago

joelbutcher commented 1 month ago

Fixes a bug where, when using Fortify::authenticateThrough in a service provider, the auth for Socialstream fails and kicks users out of the application (e.g. to the My Account page for Google OAuth).

The problem is fixed by iterating over the pipes used by Fortify (or in the custom callback) and replacing Fortify's instances of AttemptToAuthenticate and RedirectIfTwoFactorAuthenticatable with our own.

Resolves #378

[!Note] This does not solve the problem where developers create their own custom authentication implementations and don't use fortify's at all

joelbutcher commented 1 month ago

@miguilimzero this should solve your issue

miguilimzero commented 1 month ago

@joelbutcher I didn't have time to test it yet, but it looks like it will work seamlessly. Thank you for the prompt fix!