search

joelday / papyrus-lang

📜Advanced language tools for the Papyrus scripting language.
Other
111 stars 19 forks source link

Expression: "Thrown during type checking", "System.NullReferenceException" #90

Open FelesNoctis opened 5 years ago

FelesNoctis commented 5 years ago

Describe the bug Error log found here: https://pastebin.com/y81gSVYP When the extension is attempting to read and process an expression, any time the expression is incomplete it will throw this error. It appears to "jump the gun", trying to evaluate/cast empty space.

To Reproduce Steps to reproduce the behavior:

  1. Create an expression. debug.Notification("Old Value: ")
  2. Edit the expression with additional information. debug.Notification("Old Value: " +)
  3. Error appears at this point while typing.
minkir014 commented 5 years ago

I think this is ideal. This happens to all languages for me. When you leave a plus sign without something after it, it gives an error but the error disappears when I complete something after it.

FelesNoctis commented 5 years ago

What languages are you looking at? Generally it would be the job of a linter to report an error in the code, not an error breaking the extension itself.

For instance, the same expression error in Javascript:

Papyrus-Lang already has a linter, the error should be properly funneling its output there similar to everything else.

minkir014 commented 5 years ago

I didn't know it breaks the extension itself.

FelesNoctis commented 5 years ago

Yeah. The error in question is due to the extension not properly handling the circumstance in question. The VSCode error log was posted to pastebin and linked above.

joelday commented 1 year ago

This will be addressed in the rewrite in progress.