Superfish not working with touch phone

[togfather]

Hi,

I am using Superfish basic on our club web site at http://www.carrickanglingclub.co.uk. It works OK on my touch screen laptop and tablet and also on the Galaxy Note 2 phone, but for some reason does not work on my fiend's Nokia Lumia 520 touch screen phone. When the menu item is tapped it shows the drop down menu for a milisecond but there is no way to access it. Is there anything that can be done to rectify this?

Many thanks

Tog Porter

[joeldbirch]

Your JavaScript files appear to be empty.

[togfather]

Hello, I think you may have been looking at something else. I have checked the Javascript files at www.carrickanglingclub.co.uk/scripts/js and they are not empty, but contain the following information: http://www.carrickanglingclub.co.uk/scripts/js/hoverIntent.js: 114 lines of code http://www.carrickanglingclub.co.uk/scripts/js/jquery.js: 93,063 characters of code http://www.carrickanglingclub.co.uk/scripts/js/superfish.js: 257 lines of code http://www.carrickanglingclub.co.uk/scripts/js/superfish.min.js: 4,120 characters of code http://www.carrickanglingclub.co.uk/scripts/js/supersubs.js: 91 lines of code

I think if they were empty the drop down would not work at all on a touch screen but these do work on some phones, but not on the Nokia Lumia 520 phone. (They work perfectly for example on my Samsung galaxy note 2). Someone else told me they do not work on a windows 8 touch screen tablet either, but I have not seen this for myself so don't know if it is the same problem as the Lumia 520.

Best wishes

Tog Porter

[togfather]

Hello, I think you may have been looking at something else.

I have checked the Javascript files at www.carrickanglingclub.co.uk/scripts/js and they are not empty, but contain the following information:

http://www.carrickanglingclub.co.uk/scripts/js/hoverIntent.js : 114 lines of code

http://www.carrickanglingclub.co.uk/scripts/js/jquery.js : 93,063 characters of code

http://www.carrickanglingclub.co.uk/scripts/js/superfish.js : 257 lines of code

http://www.carrickanglingclub.co.uk/scripts/js/superfish.min.js : 4,120 characters of code

http://www.carrickanglingclub.co.uk/scripts/js/supersubs.js : 91 lines of code

I think if they were empty the drop down would not work at all on a touch screen but these do work on some phones, but not on the Nokia Lumia 520 phone. (They work perfectly for example on my Samsung galaxy note 2). Someone else told me they do not work on a windows 8 touch screen tablet either, but I have not seen this for myself so don't know if it is the same problem as the Lumia 520.

Best wishes

Tog Porter

From: joeldbirch [mailto:notifications@github.com] Sent: 19 February 2014 02:06 To: joeldbirch/superfish Cc: togfather Subject: Re: [superfish] Superfish not working with touch phone (#108)

Your JavaScript files appear to be empty.

— Reply to this email directly or view it on GitHub https://github.com/joeldbirch/superfish/issues/108#issuecomment-35458699 .Image removed by sender.

[joeldbirch]

Thanks for the extra information. And yet, when I click those links I get 404 Not Found errors. Do you?

[joeldbirch]

Actually, the links in your second duplicate email work. How strange.

When I checked your site yesterday the dropdowns were working in CSS-only mode (which will work on some touch screens, actually) and there were JavaScript errors which indicated that jQuery was not defined. Could you look into that, please?

[joeldbirch]

I see the original links were broken due to the colon at the end. Not so strange, then. :)

[togfather]

Hi Joel,

That is very strange.

No, I can see the code OK in my browser. (Google Chrome)

Regards

Tog

From: joeldbirch [mailto:notifications@github.com] Sent: 19 February 2014 23:56 To: joeldbirch/superfish Cc: togfather Subject: Re: [superfish] Superfish not working with touch phone (#108)

Thanks for the extra information. And yet, when I click those links I get 404 Not Found errors. Do you?

— Reply to this email directly or view it on GitHub https://github.com/joeldbirch/superfish/issues/108#issuecomment-35567054 .Image removed by sender.

[togfather]

Hello Joel,

Sorry, I don’t know what you mean by “not defined”, but here is the code in the header that relates to the drop down:

Regards

Tog

                    <script src=" http:www.carrickanglingclub.co.uk//js/hoverIntent.js"></script>

                    <script src=" http:www.carrickanglingclub.co.uk//js/superfish.js"></script>

                    <script>

                    (function($){ //create closure so we can safely use $ as alias for jQuery

                                $(document).ready(function(){

                                            // initialise plugin

                                            var example = $('#example').superfish({

                                                        //add options here if required

                                            });

                                            // buttons to demonstrate Superfish's public methods

                                            $('.destroy').on('click', function(){

                                                        example.superfish('destroy');

                                            });

                                            $('.init').on('click', function(){

                                                        example.superfish();

                                            });

                                            $('.open').on('click', function(){

                                                        example.children('li:first').superfish('show');

                                            });

                                            $('.close').on('click', function(){

                                                        example.children('li:first').superfish('hide');

                                            });

                                });

                    })(jQuery);

                    </script>

                    <!-- end of drop down script-->

From: joeldbirch [mailto:notifications@github.com] Sent: 20 February 2014 00:00 To: joeldbirch/superfish Cc: togfather Subject: Re: [superfish] Superfish not working with touch phone (#108)

Actually, the links in your second duplicate email work. How strange.

When I checked your site yesterday the dropdowns were working in CSS-only mode (which will work on some touch screens, actually) and all there were JavaScript errors which indicated that jQuery was not defined. Could you look into that, please?

— Reply to this email directly or view it on GitHub https://github.com/joeldbirch/superfish/issues/108#issuecomment-35567329 .Image removed by sender.

[joeldbirch]

Can you fix the JavaScript errors that appear in Chrome Developer Tools when on your website? Then please let me know how it behaves. See attached image.

[togfather]

Hi Joel,

Sorry, I changed the link from relative to absolute before the last message to see if it helped, but forgot the // after the http: (old age creeping in – lol)

I have fixed that now but the problem still exists.

Best wishes

Tog Porter

From: joeldbirch [mailto:notifications@github.com] Sent: 21 February 2014 02:09 To: joeldbirch/superfish Cc: togfather Subject: Re: [superfish] Superfish not working with touch phone (#108)

Can you fix the JavaScript errors that appear in Chrome Developer Tools when on your website? Then please let me know how it behaves. See attached image.

https://f.cloud.github.com/assets/75602/2226188/1c8f5a0a-9a9d-11e3-99e0-fdaf618c27c1.png screen shot 2014-02-21 at 1 07 07 pm

— Reply to this email directly or view it on GitHub https://github.com/joeldbirch/superfish/issues/108#issuecomment-35692437 . https://github.com/notifications/beacon/6605418__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODQ4MTM0OSwiZGF0YSI6eyJpZCI6MjUwODczNzh9fQ==--45b7aa3c0b84c9f69e8d07b644584d7b5f529c41.gif

[joeldbirch]

I am still seeing errors in the JS console which will definitely prevent Superfish from working. See attached.

[togfather]

Hello Joel,

I only see one error, and it does not appear every time I run the console.

It is: error 404 page not found: http://www.carrickanglingclub.co.uk/scripts/js/jquery.min.map

But there is no jquery.min.map anywhere in the code on that page !

Best wishes

Tog Porter

From: joeldbirch [mailto:notifications@github.com] Sent: 03 March 2014 05:48 To: joeldbirch/superfish Cc: togfather Subject: Re: [superfish] Superfish not working with touch phone (#108)

I am still seeing errors in the JS console which will definitely prevent Superfish from working. See attached. https://f.cloud.github.com/assets/75602/2306790/41a34994-a297-11e3-8f82-69c3710d5fa8.png errors-2

— Reply to this email directly or view it on GitHub https://github.com/joeldbirch/superfish/issues/108#issuecomment-36483251 . https://github.com/notifications/beacon/6605418__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwOTQ0NDg1MywiZGF0YSI6eyJpZCI6MjUwODczNzh9fQ==--095c5f361104c3dcccd528624f1ad3944ac5f177.gif

[joeldbirch]

It appears that the errors have been fixed. There are two reasons why Superfish isn't working as expected on your site:

1. You are not initialising the Superfish JS component as shown in step 3 of this page
2. The top level items are not inside anchor tags, which is required.

Hope this helps.