joeldbirch / superfish

Superfish is a jQuery plugin that adds usability enhancements to existing multi-level drop-down menus.
Other
912 stars 315 forks source link

Supports touch devices windows (+phone) 8 IE 11 with touchscreen #121

Closed lucky-driver closed 10 years ago

lucky-driver commented 10 years ago

Hello I'm from Germany. Sorry for my bad English.

I Use Superfish Menu in version 1.7.4 with jquery 1.9.1 and hoverIntent r7.

Also tested with jquery 1.10.1 and 1.11.1. And hoverIntent 1.8.0.

First touch will open in associated submenu, second will follow the link. Does not work.

For Windows 8 (and phone) IE 11th

Is there a solution?

http://users.tpg.com.au/j_birch/plugins/superfish/examples/ Not fuktioniert for Windows 8 (and phone) IE 11th

With best regards

joeldbirch commented 10 years ago

Hello and thanks for the report. I think IE11 implements pointer events without the ms prefix now, so that may be the cause. I'll have to look into this further.

Thanks again.

lucky-driver commented 10 years ago

Thanks for the message. I look forward to the solution!

Thank you

NanoSector commented 10 years ago

Hello,

I'm sorry to re-open this issue, but I would like to add that in Firefox it does not work either. Please see the issue I opened over at our repo: https://github.com/SimpleMachines/SMF2.1/issues/2283

joeldbirch commented 10 years ago

Thanks for the report. This is proving tricky for me as I don't currently have a windows touch device to test these browsers and develop a solution. It would be amazing if someone who does could look into it and possibly submit a pull request with a solution.

NanoSector commented 10 years ago

If there is anything we can do to be of use to you, please don't hesitate to ask. :)

joeldbirch commented 10 years ago

I have created a test branch called 'wphone' that includes code to account for IE11 deprecating prefixes for pointer events. I'm not sure if this helps your issue at all and—as I mentioned—I no longer have access to a Windows 8 Phone or Surface to test the touch interactions. If someone could try out the branched version of the code and report back with the results, that would be great.

NanoSector commented 10 years ago

Thank you, I will take a look either today or later this week. :)

lucky-driver commented 10 years ago

Hello, I tested the version (MS IE11 vendor prefix versions of the pointer events APIs have bee ...) On Windows 8.1 Surface 2 with IE11, and Windows Phone 8.1 with IE11. Superfish works without problems. Super! Many many THANKS!

NanoSector commented 10 years ago

IE11 and Opera confirmed working indeed, though Firefox on the desktop is still a no-go. (mobile works just fine if I hit the arrows) ETA: @Antes might be interested as well.

XinYenFon commented 10 years ago

Working perfectly on Windows Phone 8.1 (GRD1 - dev channel) - mobileIE11

joeldbirch commented 10 years ago

Thanks everyone for your feedback, I really appreciate it! I have released Superfish v1.7.5 with these changes so I'll close this issue. I think the Firefox issue should have its own thread, so if someone who has experienced the bug could create that, that would be great. Thanks again.