joeldesante / Harvey

Community managment Discord bot for the Old Dominion University Computer Science community.
GNU General Public License v3.0
6 stars 4 forks source link

Rename parent-channel to parent-category #48

Closed willuhmjs closed 1 year ago

willuhmjs commented 1 year ago

In setCourseRoleChannel.js, the category channel option is named parent-channel instead of parent-category, which is ambigious. The description of the command accurately describes it, so the name should as well.

.addChannelOption(new SlashCommandChannelOption()
      .setName("parent-channel") // Change this to "parent-category"
      .setDescription("The category in which the course chats will reside.")
      .setRequired(true)
)
joeldesante commented 1 year ago

Good idea. The original name is due to the fact that categories are seen as channels by discord. But from a UX perspective this makes more sense.

willuhmjs commented 1 year ago

I also recommend using the addChannelType method to the channel option of the slash command builder. This limits the parent-category channel to the category type.