search

joeldg / bowhead

PHP trading bot framework
Apache License 2.0
801 stars 288 forks source link

withoutOverlapping will actually run command every 24 hours #116

Open jankulma opened 6 years ago

jankulma commented 6 years ago

Hello,

In https://github.com/joeldg/bowhead/blob/master/app/Console/Kernel.php#L47 you use withoutOverlapping which should prevent executing a command if it is already running. But if you see this method, you'll notice that there is an argument with default value 1440 which stands for 24h. So basically the command will be run again every 24 hours, despite if it is already running or not.

Some more details: https://github.com/laravel/framework/issues/18202

I'm not sure if this is actually an issue for you. I build my own app loosely inspired by yours, and I encountered this, so I wanted to share it.

Thanks, Jan

PS I posted this twice, please delete https://github.com/joeldg/bowhead/issues/115

joeldg commented 6 years ago

thanks, will look into it.. been swamped lately