search

joeldg / bowhead

PHP trading bot framework
Apache License 2.0
801 stars 288 forks source link

OHLC.php some minutes not stored #71

Closed tombrown86 closed 6 years ago

tombrown86 commented 6 years ago

I think there is a problem here.

Some minutes don't get logged

also it seems to be inserting data for prev min (in tick) as data for the current min.. is this intended?

tombrown86 commented 6 years ago

UPDATE: I was seeing this issue in the 1m table for EUR_USD

it's because it's referencing $bf_pair throughout the function, it should be using $instrument

..so (in context of a forex pair) it was taking the last 1m entry time to be the last 1m entry time for BTC/USD :)

I will fork this + make a PR.. .eventually... I'll leave this open for the time being

rxmg-joeldg commented 6 years ago

This is all being redone now with new tables and models.. see https://github.com/joeldg/bowhead/commit/dff94eb858cc6c2ee5f75b9c1e8bab6e4156d733#diff-6be90f49f9c6d7fffa2550ba86608ce3

Reasoning is that we need to be able to track which exchange the data is coming in off. Additionally, I will be adding in a data service for this separately..

I know that does not help you now, but soon this will not be used.

tombrown86 commented 6 years ago

Good man...! can't wait to see the new stuff (and really can't wait for the ML work)

I just did a pull request anyway, in case you want the fix for the meantime

God speed