joeldipops / gbz80-pseudoOps

Set of rgbasm macros and constants to facilitate readability for modern programmers
MIT License
8 stars 1 forks source link

Misleading comment #5

Closed ISSOtm closed 5 years ago

ISSOtm commented 5 years ago

This comment states that this is for MBCs with higher ROM bank counts, when it's really per ROM, and only applies to MBC5.

joeldipops commented 5 years ago

Thanks, I hadn't tested the MBC stuff, I was just pulling it from http://gbdev.gg8.se/wiki/articles/Memory_Bank_Controllers

Specifically this section under MBC5

MBC5 (max 8MByte ROM and/or 128KByte RAM) ... 3000-3FFF - High bit of ROM Bank Number (Write Only) The 9th bit of the ROM bank number goes here.

joeldipops commented 5 years ago

Fixed