search

joelekstrom / fastmate

A native Fastmail-wrapper for Mac.
MIT License
192 stars 12 forks source link

Combine branch status? #56

Closed mdbraber closed 2 years ago

mdbraber commented 2 years ago

I'm still using my custom version of Fastmate everyday and enjoying it. I've recently been building a similar wrapper but for Todoist which I made in Swift. I saw you also created a 'combine' branch about a year ago using Swift. Do you (still) have any plans to port Fastmate from Obj-C to Swift?

joelekstrom commented 2 years ago

I do! I created that branch mostly to learn Combine, so it’s a bit problematic in the sense that it a probably “too reactive” since I deliberately tried to use it for pretty much everything to learn 😬 it does work though so feel free to fork that branch if you need.

However, take a look at the last few commits on master. I’ve started to slowly do a more sensible Swift rewrite. I pick the good parts from the Combine branch, but mostly try to do a 1-1 rewrite to Swift to keep changes minimal. When everything is migrated it’s easier to “Swiftify” stuff.

mdbraber commented 2 years ago

Great - nice to hear! Are you indeed planning on using something like Swiftify.com when the rewriting is done?

joelekstrom commented 2 years ago

No. I prefer to just rewrite it myself and improve where needed. With "Swiftify" I mean after migrating, changing to using stuff like Combine KVO publishers instead of the KVOBlockObserver it's currently using in objc. 884477df97edefd54985eaeedfe820c75333b9a4 is an example of this where I migrated to compile-time verified user default keys and KVO publishers

joelekstrom commented 2 years ago

😂 I'm sorry - I had forgotten to push the commits I talked about above. They are on master now...

posguy99 commented 2 years ago

I've recently been building a similar wrapper but for Todoist which I made in Swift.

Not that it's related to Fastmate, but I looked on your Github page and didn't see a Todoist wrapper. Are you doing anything that Todoist's own wrapper doesn't?

mdbraber commented 2 years ago

@posguy99 yes, I'm doing a native quick add window, support Applescript and integrate todoist-shortcuts to name a few. It's not ready for release yet, but works well already.