joelgoh1 / pe

0 stars 0 forks source link

Overly restrictive check on phone numbers #2

Open joelgoh1 opened 2 months ago

joelgoh1 commented 2 months ago

Description The phone numbers that can be added are restricted to only 8 characters long and can only start with 8 or 9 as stated by the user guide, and in the error message when trying to input an invalid phone number. However, considering that the app is catered to making friends in dorms, this excludes exchange students who might not have a Singaporean number. Exchange students usually stay in dorms, and hence excluding them from being added might go against the aims of the app as it prevents you from befriending exchange students.

Steps to reproduce Enter any invalid phone number, that is either not 8 characters long or does not start with 8 or 9.

Expected behaviour App should accept greater variety of phone numbers, as contacts to be added do not necessarily have to have SIngaporean phone numbers.

Actual behaviour App rejects invalid phone numbers, e.g phone numbers that are not Singaporean.

Screenshots

image.png

Reason for severity This would prevent users from befriending foreign exchange students who might not have felt a need to get a Singaporean SIM card, which goes against the aim of the application. As many dorms host foreign exchange students, this can potentially affect many users. However, they can continue using the app by adding the foreign exchange student with a dummy number instead. However, there is no way of contacting these contacts with their actual phone number, which is quite a hindrance.

soc-se-bot commented 2 months ago

Team's Response

The severity is bumped down to low as foreign students and local students will still be able to interact through other messaging platforms such as Telegram.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I still believe that this bug is of severity.Medium. As phone number is a required parameter while other messaging means like Telegram are optional parameters, this clearly indicates to a user that communication by phone number is preferred. If they enter their foreign friends' phone numbers and have it rejected, this would alarm the user, and they would be forced to either not save their contact, or memorise that they had entered an invalid phone number for this particular contact and to only contact them via telegram despite the fact that a phone number is present. This goes against the aims of a contact book as it does not help manage contacts, and conversely could even hinder the contact management process.