search

joelgoh1 / pe

0 stars 0 forks source link

Overly restrictive check on names #3

Open joelgoh1 opened 2 months ago

joelgoh1 commented 2 months ago

Description There is an overly robust check on names, allowing only alphanumeric characters. This prevents a user from adding contacts with names containing special characters like "s/o", which is not uncommon in Singapore.

Steps to reproduce add n/John s/o Doe p/68765432 e/johnd@example.com r/sw-01-01 t/johnDoe b/12/12/2000 d/PGPR ft/Mon:1300-1400

Expected behaviour New person added: John s/o Doe; Phone: 98765432; Email: johnd@example.com; Room Number: sw-01-01; Telegram: johnDoe; Birthday: 12 December 2000; Dorm Tag: [PGPR]; Free Time Tags: [Mon:1300-1400]

Actual behaviour Names should only contain alphanumeric characters and spaces, and it should not be blank

Screenshots

image.png

Reason for severity This can prevent users from entering names of their friends, however there are workarounds such as entering "son of" instead of "s/o"

soc-se-bot commented 2 months ago

Team's Response

We mentioned in our planned enhancements in the DG that we intend to support more forms of names by allowing non-alphanumeric symbols which includes "/" so that s/o can be in the name field.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]