joelgombin / banR

R client for the BAN API
http://joelgombin.github.io/banR/
GNU General Public License v3.0
28 stars 10 forks source link

Release 0.2.2 #26

Closed romainfrancois closed 4 years ago

romainfrancois commented 4 years ago

La version 0.2.1 du CRAN échoue contre dplyr 1.0.0 avec ces messages:

[master*] 126 MiB ❯ revdepcheck::revdep_details(, "banR")
══ Reverse dependency check ══════════════════════════════════════ banR 0.2.1 ══

Status: BROKEN

── Newly failing

✖ checking tests ...

── Before ──────────────────────────────────────────────────────────────────────
0 errors ✔ | 0 warnings ✔ | 0 notes ✔

── After ───────────────────────────────────────────────────────────────────────
❯ checking tests ...
  See below...

── Test failures ───────────────────────────────────────────────── testthat ────

> library("testthat")
> library("banR")
> test_check("banR")
── 1. Failure: Code INSEE and Code postal return the same result (@test_geocodet
geocode_tbl(tbl = table_check, adresse = num_voie, code_postal = cp) not equivalent to geocode_tbl(tbl = table_check, adresse = num_voie, code_insee = codecommune).
Component 1: 2 string mismatches
Component 2: 2 string mismatches
Component 4: 2 string mismatches

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 7 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
1. Failure: Code INSEE and Code postal return the same result (@test_geocodetbl.R#77)

Error: testthat unit tests failed
Execution halted

1 error ✖ | 0 warnings ✔ | 0 notes ✔

mais apparemment c'est déjà réparé. Es-ce que vous avez prévu de sortir une 0.2.2 avant la sortie de dplyr ?

pachevalier commented 4 years ago

Je vais essayer de regarder

joelgombin commented 4 years ago

C'est juste un problème sur le test, hadley explique dans son dernier blog post le problème, je peux regarder aussi ce week end

Le jeu. 7 mai 2020 à 15:40, Paul-Antoine notifications@github.com a écrit :

Je vais essayer de regarder

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/joelgombin/banR/issues/26#issuecomment-625262354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOUOD2NJ2XSHBWFU3322GTRQK25NANCNFSM4MYQQBNQ .

joelgombin commented 4 years ago

The release has been submitted to CRAN.

joelgombin commented 4 years ago

on its way to CRAN 🍾