search

joelgombin / banR

R client for the BAN API
http://joelgombin.github.io/banR/
GNU General Public License v3.0
28 stars 10 forks source link

Adding geocode_csv() and geocode_csv_reverse() function #28

Open feddelegrand7 opened 3 years ago

feddelegrand7 commented 3 years ago

Hi I've added the following which I think may complement well the current features of the package:

  1. Adding the geocode_csv() function
  2. Adding the geocode_csv_reverse() function
  3. Both function are documented (Rd files added)
  4. Both functions are documented within the vignetter Rmd

Best regards.

feddelegrand7 commented 3 years ago

Hi @joelgombin thanks for your feedback. You're absolutely right, columns = c("postcode", "adresse") would be way more efficient for the end user and is R friendly however to be honest I've tried to pass a vector to the body paramater of the POST() function (and a list also) but it didn't work, that's why I used the .... Any solution for that ?

pachevalier commented 3 years ago

What's the diff with tbl_geocode?