search

joelgrus / data-science-from-scratch

code for Data Science From Scratch book
MIT License
8.63k stars 4.5k forks source link

No images in repo #79

Closed xmbn closed 5 years ago

xmbn commented 5 years ago

There should be some images in the "im" folder but it's empty. This causes an error when importing inverse_normal_cdf from scratch. probability. It's looking for "various_normal_pdfs.png"

joelgrus commented 5 years ago

actually, it just wants the im directory to write images in it itself, but that's still bad.

just comment out the plt.savefig line, I'll do that in the repo too

xmbn commented 5 years ago

Thanks Joel. That makes sense. Once I viewed the code I realized it's not just a library, there's code that runs in there when it's imported. Commenting out works fine.

On Sat, Sep 28, 2019, 8:29 PM Joel Grus notifications@github.com wrote:

actually, it just wants the im directory to write images in it itself, but that's still bad.

just comment out the plt.savefig line, I'll do that in the repo too

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/joelgrus/data-science-from-scratch/issues/79?email_source=notifications&email_token=ANKXWQQV764CMWT2CNAKIOLQMAAGBA5CNFSM4I3QIF42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD73FSXY#issuecomment-536238431, or mute the thread https://github.com/notifications/unsubscribe-auth/ANKXWQW5J2MZ6UNO6ARUY2DQMAAGBANCNFSM4I3QIF4Q .