search

joelhans / astrolabe

A literary magazine in the form of a dynamic universe.
https://astrolabe.ooo
MIT License
11 stars 1 forks source link

Add typescript #87

Closed akattow closed 1 year ago

akattow commented 1 year ago

Hey Joel! Here's an initial install of Typescript. I've converted the Universe as an initial example - I think it could benefit from strong typing & make it easier to make updates/changes in the future. There's definitely still improvements to be made (see: way too many any types for starters!) but this is functional without any major changes to the existing code.

Let me know what you think! I'd love to make some more updates if you dig this (the Universe is fun!)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
astrolabe ❌ Failed (Inspect) Feb 1, 2023 at 4:42PM (UTC)
joelhans commented 1 year ago

Hey @akattow! Thanks so much for this, and for your patience as I work my way through being burned out from development work after we launched. So many things to fix! But I'm making my way back now.

This looks really good in principle, and it runs/builds just fine, so that's great! I'm going to take a bit of time to checkout the PR locally, get my development environment set up, and make sure I understand the implications of working in types. More in a day or two!

akattow commented 1 year ago

No worries!! I figured you were super busy with launch & opening up subs & the holidays, seems like a LOT of work! No rush at all, this was a fun break for me :)

joelhans commented 1 year ago

Hey @akattow! I think I'm ready to merge this—I think the best way for me to learn TypeScript is to put it into action—but it looks like a recent commit of mine created a merge conflict. If you can get that fixed without too much trouble I'll go ahead and approve/merge!

akattow commented 1 year ago

hey @joelhans! sorry for the delay, but the merge conflicts are resolved