joelhawksley / timeframe

Other
2 stars 0 forks source link

Add Git Lint #40

Open bkuhlmann opened 1 year ago

bkuhlmann commented 1 year ago

Overview

Heya. :wave: Would it be OK to add Git Lint to this project? Having a coding buddy as part of the team will allow us to communicate effectively but also document the design and architecture of this project better. To provide a bit more background, these articles might be of interest:

If approved, this would require upgrading to Ruby 3.1.x (can open a separate issue for tackling the Ruby upgrade if that'd be better) but would allow us to use Git Lint both locally and on CI. The wiring within GitHub Actions would take very little effort. :rocket:

joelhawksley commented 6 months ago

I have overcommit in place, do you think Git Lint is worth adding as well?

bkuhlmann commented 6 months ago

Well, you'd want one or the other but not both since there is overlap. Git Lint is more powerful than Overcommit but, hey, I'm biased. 😅

If you're a heavy Overcommit user, I'd probably stick with it. I use Git Lint for everything so wanted to ask. Feel free to close this if you don't want to pursue this, though.