search

joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Issue 13: graceful Network.localhostIsIPv6() call #14

Closed whaley closed 11 years ago

whaley commented 11 years ago

Added a gracefully failing call to Network.localhostIsIPv6() in StartEmbeddedMongoMojo.

Also, updated src/test/resources/example/pom.xml to have a project.version that's the same as in the main pom.

buildhive commented 11 years ago

Joe Littlejohn » embedmongo-maven-plugin #27 SUCCESS This pull request looks good (what's this?)

joelittlejohn commented 11 years ago

Thanks for pushing this @whaley!

I wonder whether it would be better to add that this fix upstream. @michaelmosmann, @matlockx any thoughts on why this is failing? Would you be interested in applying a similar fix in the flapdoodle api?

(See issue #13 btw)

michaelmosmann commented 11 years ago

I will fix this (as soon as i can (which would be monday)) in the flapdoodle.api..this way it should work as expected.. :)

thanks for your input..

joelittlejohn commented 11 years ago

@michaelmosmann I've raised a PR on embed.process.

@whaley I'll close this one for now and pull in the next embed.process release when the fix is ready. Thanks again for raising this!