search

joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Configuration parameters logFile and logFileEncoding are final #22

Closed dietrichatadobe closed 11 years ago

dietrichatadobe commented 11 years ago

The members "logFile" and "logFileEncoding" in StartEmbeddedMongoMojo.java are final, making them non-configurable.

joelittlejohn commented 11 years ago

I'm slightly baffled by how I managed to change these, but I'll fix it ASAP and cut another release.

dietrichatadobe commented 11 years ago

:thumbsup:

joelittlejohn commented 11 years ago

It looks like I've fallen foul of my Eclipse save actions here, rather over-zealously applying my coding standard. The way these defaults were set (and the requirement for Maven mojo properties to be private) means that they are assumed to be best marked final.

I've moved the default values into the Maven metadata (where they belong) so this shouldn't happen again. I've released 0.1.9 too so you should expect to see it in Maven central in the next couple of hours.