search

joelittlejohn / embedmongo-maven-plugin

Maven plugin wrapper for the flapdoodle.de embedded MongoDB API
Apache License 2.0
88 stars 51 forks source link

Change de.flapdoodle.embed.mongo to 1.40. #35

Closed cortiz closed 10 years ago

cortiz commented 10 years ago

Change Documentations to be maven 3.1 3.0 Change de.flapdoodle.embed.mongo to 1.40,

joelittlejohn commented 10 years ago

Thanks for taking the time to upgrade this @cortiz. I'm interested to know if there was anything in particular that caused you to make these changes? Anything worth mentioning in the release notes?

cortiz commented 10 years ago

We update maven to 3.1 using java 7 , after the update on stop it throws some errors ( I can send you the actual exception) it have something to do with https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues/23

cortiz commented 10 years ago

Exception in thread "Thread-27" java.lang.NoClassDefFoundError: org/apache/commons/io/FileUtils at de.flapdoodle.embed.process.io.file.Files.forceDelete(Files.java:104) at de.flapdoodle.embed.process.store.ArtifactStore.removeExecutable(ArtifactStore.java:72) at de.flapdoodle.embed.process.store.CachingArtifactStore$FileWithCounter.forceDelete(CachingArtifactStore.java:149) at de.flapdoodle.embed.process.store.CachingArtifactStore.removeAll(CachingArtifactStore.java:92) at de.flapdoodle.embed.process.store.CachingArtifactStore$CacheCleaner.run(CachingArtifactStore.java:169) at java.lang.Thread.run(Thread.java:744) Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.FileUtils at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50) at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235) at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227) ... 6 more

joelittlejohn commented 10 years ago

Carlos, this PR seems to break Maven 2.x support and I don't think there's a need to do this. This is due to swapping expression for property in the mojo. All versions of Maven 2.x and above seem to support expression but only 3.x supports property.

Could you remove this change from the PR? (Or do you need it?) If you amend this commit and force push this PR will update automatically.

cortiz commented 10 years ago

done, On maven 3.1 expression are deprecated

joelittlejohn commented 10 years ago

I removed a few of the whitespace changes and merged into master. Thanks again Carlos!

cortiz commented 10 years ago

sure any time. Any idea when its the next release (in to mvn central)

cortiz commented 10 years ago

any places to release it to MVN central ?

joelittlejohn commented 10 years ago

@cortiz: I'm currently travelling but I'll cut a new release on my return next week.

joelittlejohn commented 10 years ago

@cortiz this has now been released (0.1.10) and should be visible in maven central in a few hours

lure commented 10 years ago

Same Exception in thread "Thread-27" java.lang.NoClassDefFoundError: org/apache/commons/io/FileUtils here. can't figure out from this thread what you decided to do with it. May I ask for explanation please? :)

cortiz commented 10 years ago

That exception happened to me on mvn 3.1 and 0.1.9. therefor the upgrade to de.flapdoodle.embed.mongo to 1.40

lure commented 10 years ago

I have no de.flapdoodle.embed.mongo in my pom.xml. How exactly it can be upgraded? mvn 3.1.1, embedmongo-maven-plugin 0.1.10

cortiz commented 10 years ago

de.flapdoodle.embed.mongo to 1.40 is a dep of embedmongo-maven-plugin 0.1.10

lure commented 10 years ago 
  de.flapdoodle.embed.mongo to 1.40 is a dep of embedmongo-maven-plugin 0.1.10

I have it already as I mentioned above :) and exception still exists. What do i miss?

cortiz commented 10 years ago

try to delete from your repo com/github/joelittlejohn/* and force it to download it again

lure commented 10 years ago

it was de/flapdoodle/embed who had to be deleted. Thanks a lot for your concern and help!